[PATCH] D48974: [DomTreeUpdater] Ignore updates when both DT and PDT are nullptrs

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 09:04:03 PDT 2018


brzycki added a comment.

> (call delBB() still pends BasicBlock deletion until a flush event according to the doc).

This is an interesting idea as it gives callers a deferred deletion tool for `Lazy` and both trees are nullptr. It'd be worthwhile to add documentation somewhere to let others know about this.  I know of at least one case when I was working on JumpThreading that the original code flushed `LVI` information about a block because it called an external routine that might delete the block (it was at the end of `runImpl()`). This feature gives others a simple way of calling potentially destructive calls, checking the return code, and cleaning up on success or failure.


Repository:
  rL LLVM

https://reviews.llvm.org/D48974





More information about the llvm-commits mailing list