[PATCH] D48967: [Dominators] Convert existing passes and utils to use the DomTreeUpdater class

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 09:04:02 PDT 2018


kuhar added inline comments.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:409
+          TryToSimplifyUncondBranchFromEmptyBlock(&BB, DTU)) {
+        // BB is valid for cleanup here because we passed in DTU. F remains
+        // BB's parent until a DTU->getDomTree() event.
----------------
kuhar wrote:
> nit: I think formatting is a bit off here. Can you run clang-format on this snippet?
Ah, it's because of the really long if condition...


https://reviews.llvm.org/D48967





More information about the llvm-commits mailing list