[PATCH] D48765: [X86] The TEST instruction is eliminated when BSF/TZCNT is used

Ivan Kulagin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 9 01:39:54 PDT 2018


ikulagin updated this revision to Diff 154546.
ikulagin added a comment.

> Or you should just check the CC in the first if, then select your Add and your possible constant. And check that it is an Add and a constant.

DONE.

> Probably should make sure the add only has one user. Otherwise you're increasing code size.

DONE.

> We need tests cases that use tzcnt too.

Tests added.


Repository:
  rL LLVM

https://reviews.llvm.org/D48765

Files:
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86InstrInfo.cpp
  test/CodeGen/X86/dagcombine-select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48765.154546.patch
Type: text/x-patch
Size: 5614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180709/725e6063/attachment-0001.bin>


More information about the llvm-commits mailing list