[PATCH] D48278: [SelectionDAG] Fold redundant masking operations of shifted value

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Like @spatel I'm not clear on what you're really trying to accomplish here - has the arm/arm64 codegen improved?



================
Comment at: test/CodeGen/AArch64/FoldRedundantShiftedMasking.ll:1
+; RUN: llc -march=aarch64 < %s | FileCheck %s -check-prefix=A64
+
----------------
There's no need to use a check-prefix, remove it and use CHECK


================
Comment at: test/CodeGen/AArch64/FoldRedundantShiftedMasking.ll:88
+; A64-NEXT:	orr	w0, w9, w8
+; A64-NEXT:		ret
+; A64-LABEL:shl_nogood2:                            // @shl_nogood2
----------------
Confusing - please move the shl_nogood checks before the shl_nogood2 define


================
Comment at: test/CodeGen/ARM/FoldRedundantShiftedMasking.ll:4
+
+; RUN: llc -march=arm < %s | FileCheck %s -check-prefix=ARM
+
----------------
There's no need to use a check-prefix, remove it and use CHECK


================
Comment at: test/CodeGen/ARM/FoldRedundantShiftedMasking.ll:89
+; ARM-NEXT:	orr	r0, r1, r0
+; ARM-NEXT:	mov	pc, lr
+; ARM-LABEL:shl_nogood2:
----------------
Confusing - please move the shl_nogood checks before the shl_nogood2 define


https://reviews.llvm.org/D48278