[PATCH] D49043: [llvm-objdump] Add -demangle (-C) option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1525
+        DemangledSymbol =
+            itaniumDemangle(SymbolName.data(), DemangledSymbol, &Size, &Status);
+        if (Status == 0) // Success
----------------
alexshap wrote:
> just in case -  why does it always use itaniumDemanlge / what about other ABIs ?
This is related to @davide remark. As he pointed, for now, we will only handle this ABI :)


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1531-1532
+
+        if (Size != 0)
+          free(DemangledSymbol);
+      } else
----------------
davide wrote:
> Why not `freeing` always on success? Do you really need to look at the size?
Because not having success doesn't mean there was no allocation ?


Repository:
  rL LLVM

https://reviews.llvm.org/D49043