[PATCH] D47719: Disable ENABLE_EXPORTS for NetBSD static linking

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

While I understand the motivation, this is not the correct fix.

For example, this will almost certainly break the JIT unittests.

This function is designed to mutate a target such that it exports its dynamic symbols. If the linker is not doing the correct thing when we link using `-Wl,--export-dynamic`, then either the linker is broken or we need to customize CMake to use a different flag to the linker on NetBSD (much like we do on Apple platforms).

But the important thing is that this function still needs to serve its purpose of making the executable export dynamic symbols. You can't just turn that off silently on NetBSD -- things are actually relying on it.


Repository:
  rL LLVM

https://reviews.llvm.org/D47719