[PATCH] D49039: [BitcodeReader] Infer the correct runtime preemption for GlobalValue

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D49039#1154866, @steven_wu wrote:

> In https://reviews.llvm.org/D49039#1154801, @vsk wrote:
>
> > Thanks for doing this!
> >
> > Could you add a test? Adding "opt -verify <old-bitcode-file>" run lines to the compatibility tests would be fine.
>
>
> You will be surprise how many things will break if you run verifier on old bitcode file. The first error you will hit is not about dso_local: Global is marked as dllimport, but not external


In that case, we can enable verification on checked-in bitcode files as a follow-up. How about testing this by round-tripping textual IR through llvm-as and llvm-dis? You just need a function, alias, and global var with local linkage and without dso_local set, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D49039