[llvm] r336469 - [PDB] memicmp only exists on Windows, use StringRef::compare_lower instead

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 6 14:56:57 PDT 2018


Author: d0k
Date: Fri Jul  6 14:56:57 2018
New Revision: 336469

URL: http://llvm.org/viewvc/llvm-project?rev=336469&view=rev
Log:
[PDB] memicmp only exists on Windows, use StringRef::compare_lower instead

Modified:
    llvm/trunk/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp

Modified: llvm/trunk/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp?rev=336469&r1=336468&r2=336469&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp Fri Jul  6 14:56:57 2018
@@ -98,8 +98,8 @@ static bool gsiRecordLess(StringRef S1,
   if (LLVM_UNLIKELY(!isAsciiString(S1) || !isAsciiString(S2)))
     return memcmp(S1.data(), S2.data(), LS) < 0;
 
-  // Both strings are ascii, use memicmp.
-  return memicmp(S1.data(), S2.data(), LS) < 0;
+  // Both strings are ascii, perform a case-insenstive comparison.
+  return S1.compare_lower(S2.data()) < 0;
 }
 
 void GSIHashStreamBuilder::finalizeBuckets(uint32_t RecordZeroOffset) {




More information about the llvm-commits mailing list