[PATCH] D49039: [BitcodeReader] Infer the correct runtime preemption for GlobalValue
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 6 14:21:00 PDT 2018
vsk added a comment.
Thanks for doing this!
Could you add a test? Adding "opt -verify <old-bitcode-file>" run lines to the compatibility tests would be fine.
================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:2927
+ if (NewGV->hasLocalLinkage() ||
+ (!NewGV->hasDefaultVisibility() && !NewGV->hasExternalWeakLinkage())) {
----------------
Could you factor this out into a helper which accepts a `GlobalValue &`?
Repository:
rL LLVM
https://reviews.llvm.org/D49039
More information about the llvm-commits
mailing list