[lld] r336435 - [ELF] - Remove dead code. NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 6 14:16:13 PDT 2018


Maybe we don't have to -- line number is always equal to or greater than 1,
and the code to check if Pos==0 was a silly mistake (that's probably
written by me). If we have to assert that here, we would have to add a lot
of assertions to this file.

On Fri, Jul 6, 2018 at 1:31 PM Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Fri, Jul 6, 2018 at 6:28 AM George Rimar via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > Author: grimar
> > Date: Fri Jul  6 06:23:49 2018
> > New Revision: 336435
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=336435&view=rev
> > Log:
> > [ELF] - Remove dead code. NFC.
> >
> > 'Pos' can never be 0.
> >
>
> should this be an assert then?
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180706/16525b34/attachment.html>


More information about the llvm-commits mailing list