[PATCH] D49043: [llvm-objdump] Add -demangle (-C) option

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1526
+            itaniumDemangle(SymbolName.data(), DemangledSymbol, &Size, &Status);
+        if (Status == 0) // Success
+          outs() << '\n' << DemangledSymbol << ":\n";
----------------
This comment is probably too trivial to be useful.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1531-1532
+
+        if (Size != 0)
+          free(DemangledSymbol);
+      } else
----------------
Why not `freeing` always on success? Do you really need to look at the size?


Repository:
  rL LLVM

https://reviews.llvm.org/D49043