[PATCH] D48815: [VPlan] Introduce VPlan-based dominator analysis.

[Diego Caballero via Phabricator via llvm-commits]

dcaballe added inline comments.


================
Comment at: unittests/Transforms/Vectorize/VPlanDominatorTreeTest.cpp:20
+/// Build the VPlan plain CFG for the loop nest in function \p FuncName.
+static std::unique_ptr<VPlan> buildVPlanPlainCFG(Module &M,
+                                                 StringRef FuncName) {
----------------
fhahn wrote:
> I've put up D49032 for review, which adds a VPlanTestBase class which can be re-used by different tests to construct modules & VPlans. What do you think? I can adjust the interface so it matches the one described here. What do you think? :)
It sounds pretty good! Much cleaner! I approved it but feel free to change it to match the interfaces here. I'll have a look at it again.
I'll rebase this patch on top of that once it's ready.


Repository:
  rL LLVM

https://reviews.llvm.org/D48815