[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 6 08:33:41 PDT 2018


ldionne updated this revision to Diff 154415.
ldionne added a comment.

This revision to the patch fixes a problem where __pbump had been applied
_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY instead of _LIBCPP_INLINE_VISIBILITY,
which caused the symbols exported in the ABI to change and broke the CI.

Independently, LLDB tests that were failing because they relied on
_LIBCPP_INLINE_VISIBILITY were fixed so that this change should not
break them again.

I still haven't been able to run the ABI tests locally (they fail on my
machine), and I'd like to do that before I submit this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D48892

Files:
  libcxx/docs/DesignDocs/VisibilityMacros.rst
  libcxx/include/__bsd_locale_fallbacks.h
  libcxx/include/__config
  libcxx/include/__locale
  libcxx/include/__nullptr
  libcxx/include/any
  libcxx/include/cmath
  libcxx/include/codecvt
  libcxx/include/exception
  libcxx/include/experimental/dynarray
  libcxx/include/experimental/filesystem
  libcxx/include/functional
  libcxx/include/future
  libcxx/include/initializer_list
  libcxx/include/ios
  libcxx/include/locale
  libcxx/include/math.h
  libcxx/include/memory
  libcxx/include/new
  libcxx/include/ostream
  libcxx/include/regex
  libcxx/include/stdexcept
  libcxx/include/streambuf
  libcxx/include/support/android/locale_bionic.h
  libcxx/include/support/xlocale/__posix_l_fallback.h
  libcxx/include/support/xlocale/__strtonum_fallback.h
  libcxx/include/system_error
  libcxx/include/typeinfo
  libcxx/include/vector
  libcxx/src/support/win32/thread_win32.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48892.154415.patch
Type: text/x-patch
Size: 87676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180706/946f3bdd/attachment.bin>


More information about the llvm-commits mailing list