[PATCH] D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7698
+      if (ResultType != Val.getValueType() &&
+          ResultType.getSizeInBits() == Val.getValueSizeInBits()) {
         Val = DAG.getNode(ISD::BITCAST, getCurSDLoc(),
----------------
Is this change necessary?  getCopyFromRegs should do the appropriate int->float bitcast, I think.


================
Comment at: test/CodeGen/ARM/pr34170.ll:1
+; RUN: llc -mtriple armv7-arm-linux-gnueabihf -O2 -mcpu=cortex-a7 < %s | FileCheck %s
+
----------------
Please pick a different filename for this file.  And I'd like to see tests for float and double inputs and outputs, in both soft-float and hard-float modes.


Repository:
  rL LLVM

https://reviews.llvm.org/D45376