[PATCH] D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC)

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

@ruiu what is the consensus on this? What would be a practical use-case for escaping double-quotes?

File names can already be ruled out on Windows, as double quotes are reserved <https://docs.microsoft.com/en-us/windows/desktop/FileIO/naming-a-file>.

That could happen if one is linking a COFF target on Linux system? However in that case the 'cmd' field in the PDB will not be reusable afterwards on a Windows system, which is the whole purpose of this change. If that happens, we should rather warn if reserved Windows characters are used in the 'cmd' field?

As a counter-example, /manifestuac uses single quotes to prevent such issues: `/manifestuac:"level='asInvoker' uiAccess='false'"`


https://reviews.llvm.org/D46427