[PATCH] D45213: [COFF][LLD] Add link support for precompiled headers .objs

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/PDB.cpp:258
+maybeReadRecord(CVTypeArray &Types, const uint32_t RecordTypeValue,
+                const bool drop = false) {
   auto I = Types.begin();
----------------
zturner wrote:
> Variable names should be `CamelCase`.
Generally we avoid optional parameters. Please always explicitly pass true or false.


================
Comment at: lld/COFF/PDB.cpp:464
 
+const CVIndexMap &PDBLinker::aquirePrecompObj(ObjFile *File,
+                                              PrecompRecord &Precomp) {
----------------
Please add a function comment explaining what this function is for.

This function seems a bit too long to me. Please consider splitting into smaller functions.


https://reviews.llvm.org/D45213