[PATCH] D48892: [libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY

[Davide Italiano via Phabricator via llvm-commits]

davide reopened this revision.
davide added a comment.
This revision is now accepted and ready to land.

The lldb bot started failing very recently and the blamelist hints at this change.

http://green.lab.llvm.org/green/job/lldb-cmake/7777/

Can you please take a look?

For your convenience, this is failing building LibCxx testcases with a linker error:

  Build Command Output:
  Undefined symbols for architecture x86_64:
    "std::__1::__vector_base_common<true>::__vector_base_common()", referenced from:
        std::__1::__vector_base<int, std::__1::allocator<int> >::__vector_base() in main.o
        std::__1::__vector_base<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >::__vector_base() in main.o
  ld: symbol(s) not found for architecture x86_64
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
  make: *** [a.out] Error 1


Repository:
  rCXX libc++

https://reviews.llvm.org/D48892