[PATCH] D48983: [libc++] Replace incorrect visibility on a streambuf method

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 11:18:09 PDT 2018


ldionne created this revision.
ldionne added reviewers: EricWF, mclow.lists.
Herald added subscribers: llvm-commits, dexonsmith, christof.

In r336369, I replaced `_LIBCPP_ALWAYS_INLINE` by `_LIBCPP_INLINE_VISIBILITY`.
However, in one place, I replaced it by `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY`
and forgot to put it back before sending the review. Nobody spotted the subtle
mistake because the diff was so large. This broke the check-cxx-abilist test.

This commit fixes that.


Repository:
  rL LLVM

https://reviews.llvm.org/D48983

Files:
  libcxx/include/streambuf


Index: libcxx/include/streambuf
===================================================================
--- libcxx/include/streambuf
+++ libcxx/include/streambuf
@@ -258,7 +258,7 @@
     inline _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
     void pbump(int __n) { __nout_ += __n; }
 
-    _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
+    _LIBCPP_INLINE_VISIBILITY
     void __pbump(streamsize __n) { __nout_ += __n; }
 
     inline _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48983.154274.patch
Type: text/x-patch
Size: 467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180705/52950ba7/attachment.bin>


More information about the llvm-commits mailing list