[PATCH] D48975: [DAG] Support non-uniform X%C -> X-(X/C)*C folds
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 5 10:41:54 PDT 2018
efriedma added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3263
AddToWorklist(Div.getNode());
SDValue OptimizedDiv = combine(Div.getNode());
if (OptimizedDiv.getNode() && OptimizedDiv.getNode() != Div.getNode() &&
----------------
Instead of doing this weird recursive combine() dance, can we just call BuildSDIV() or whatever directly? Not exactly part of your patch, but it's difficult to follow what code actually runs here, and it only gets more complicated with vectors.
Repository:
rL LLVM
https://reviews.llvm.org/D48975
More information about the llvm-commits
mailing list