[PATCH] D48825: [DAGCombiner] Add EXTRACT_SUBVECTOR to SimplifyDemandedVectorElts

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 5 10:38:44 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:1487
+    unsigned NumSrcElts = Src.getValueType().getVectorNumElements();
+    APInt Idx = cast<ConstantSDNode>(Op.getOperand(1))->getAPIntValue();
+    if (Idx.uge(NumSrcElts - NumElts))
----------------
const APInt &? It doesn't look like we need a copy.


Repository:
  rL LLVM

https://reviews.llvm.org/D48825





More information about the llvm-commits mailing list