[PATCH] D48972: [ARM][NFC] ParallelDSP tweaks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:42
 namespace {
-  struct ParallelMAC;
+  struct BinOpSequence;
   struct Reduction;
----------------
Bikeshedding names: was thinking if e.g. BinOpChain is capturing it better? 


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:461
+static void AliasCandidates(BasicBlock *Header,
+                            BinOpSequenceList &MACCandidates,
+                            Instructions &Aliases) {
----------------
Should we then also rename argument 'MACCandidates' in to e.g. just Candidates to also make that generic?


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:490
 static bool AreAliased(AliasAnalysis *AA, Instructions AliasCandidates,
-                       ParallelMACList &MACCandidates) {
+                       BinOpSequenceList &MACCandidates) {
   LLVM_DEBUG(dbgs() << "Alias checks:\n");
----------------
Same here?


https://reviews.llvm.org/D48972