[PATCH] D48935: [llvm-exegesis] Provide a way to handle memory instructions.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Thanks for the comments !



================
Comment at: tools/llvm-exegesis/lib/Target.cpp:33
   }
-  assert(Target->Next == nullptr && "target has already been registered");
   if (Target->Next != nullptr)
+    return; // Already registered.
----------------
filcab wrote:
> Why is the assert being removed? It seemed to be asserting that we don't call this function twice. Are we now possibly calling it twice, or would it still be a programmer problem (as in: we should try to guarantee that the function is only called once).
Unit tests are actually calling it twice unfortunately. It allows having a single binary for all tests rathen than one binary per test and reduces link time quite importantly.


Repository:
  rL LLVM

https://reviews.llvm.org/D48935