[PATCH] D48905: [ADT] Guard our use of function pointers in a `PointerUnion` by a dynamic check that the pointer is actually sufficiently aligned.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc abandoned this revision.
chandlerc added a comment.

I'm gonna abandon this and submit a different patch.

It has really bad properties. In a bunch of cases the pointers still aren't aligned and with this patch when they *happen* to fall on 4-byte boundaries we'll end up embedding a pointer. This makes things like debugging awful due to the highly dynamic aspect of everything.

I'm going to add a layer of indirection until we have some much more reliable pattern here. It makes me really sad to have to do the layer of indirection, but this is breaking too many bots...


Repository:
  rL LLVM

https://reviews.llvm.org/D48905