[PATCH] D48904: [llvm-objdump] Add --archive-headers (-a) option

[Paul Semel via Phabricator via llvm-commits]

paulsemel updated this revision to Diff 154193.
paulsemel marked 4 inline comments as done.
paulsemel added a comment.

Ok, so it appears that I can't trigger the error anymore, because I move the call to `printArchiveChild` to the `DumpObject` function.
In the `DumpArchive` function, when the object is ill-formed, we are just ignoring and going to the next file.
I think we can let it like this, as it is barely not possible to test the behavior now..


Repository:
  rL LLVM

https://reviews.llvm.org/D48904

Files:
  test/tools/llvm-objdump/Inputs/liblong_filenames.a
  test/tools/llvm-objdump/archive-headers-disas.test
  test/tools/llvm-objdump/archive-headers.test
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48904.154193.patch
Type: text/x-patch
Size: 9294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180705/cd34be1a/attachment.bin>