[PATCH] D48930: [InstCombine] Apply foldICmpUsingKnownBits to early bailout case

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 4 21:35:22 PDT 2018


aditya_nandakumar added a comment.

In https://reviews.llvm.org/D48930#1152669, @mkazantsev wrote:

> In https://reviews.llvm.org/D48930#1152458, @spatel wrote:
>
> > In https://reviews.llvm.org/D48930#1152437, @mkazantsev wrote:
> >
> > > The context is following: the patch https://reviews.llvm.org/rL336172 has broken this test, and I was asked to fix it.
> >
> >
> > I assumed that much. :)
> >  But are there any other examples that were given to you? The solution may depend on how varied the breakage is. If it's just this case, then we can probably get by with a solution that doesn't need value tracking.
>
>
> It's the only example I have. @aditya_nandakumar, do you have any more tests where it matters?


That was the simplest test case where I observed regression. There were quite a few more  - I didn't get a chance to look at them all.


https://reviews.llvm.org/D48930





More information about the llvm-commits mailing list