[PATCH] D48907: [ARM] Treat cmn immediates as legal in isLegalICmpImmediate.

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:3861
+    if (!isLegalICmpImmediate((int32_t)C) ||
+        (C == -1U && (CC == ISD::SETLE || CC == ISD::SETGT))) {
+      // Constant does not fit, try adjusting it by one.
----------------
I don't understand what this is trying to do, why the special case? Surely the fix in isLegalICmpImmediate is enough?


Repository:
  rL LLVM

https://reviews.llvm.org/D48907