[PATCH] D48920: [NEON] Fix combining of vldx_dup intrinsics with updating of base addresses

[Diogo N. Sampaio via Phabricator via llvm-commits]

dnsampaio added a comment.

Hi Ivan,
The patch fixes the crash, but I would like to know if the desired updates aren't already done, just needing to copy paste them?
Cheers
Diogo



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:11492
+        // combining base updates for such intrinsics.
+        continue;
       case Intrinsic::arm_neon_vld2lane: NewOpc = ARMISD::VLD2LN_UPD;
----------------
Perhaps I got something wrong, but the desired actions for these 3 intrinsics aren't already defined in the "else" statement below, where it already receives the desired node type? Just need to define isLane=true and NumVecs and NewOpc accordingly.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:11518-11521
       case ARMISD::VLD1DUP: NewOpc = ARMISD::VLD1DUP_UPD; NumVecs = 1; break;
       case ARMISD::VLD2DUP: NewOpc = ARMISD::VLD2DUP_UPD; NumVecs = 2; break;
       case ARMISD::VLD3DUP: NewOpc = ARMISD::VLD3DUP_UPD; NumVecs = 3; break;
       case ARMISD::VLD4DUP: NewOpc = ARMISD::VLD4DUP_UPD; NumVecs = 4; break;
----------------
Actions defined here.


https://reviews.llvm.org/D48920