[PATCH] D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work.

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerInternal.h:155
 
+struct ScopedEnableMsanInterceptorChecks {
+  ScopedEnableMsanInterceptorChecks() {
----------------
kcc wrote:
> you only ever need ScopedEnable, right? 
> never ScopedDisable
Technically yes, we could avoid re-enabling after the write in `DumpCurrentUnit`, since `DumpCurrentUnit` is currently only ever called right before crashing.  But I'm not sure we want to bank on that...

Since `DumpCurrentUnit` doesn't crash itself, a future change could end up calling it outside of a crash handler.  If that happens, we would have a tricky bug where MSan's interceptor checks are permanently disabled.


https://reviews.llvm.org/D48891