[PATCH] D48247: lld: add experimental support for SHT_RELR sections.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1783
+
+    Elf_Relr R;
+    if (Bits == 0) {
----------------
rahulchaudhry wrote:
> ruiu wrote:
> > Please use `typename ELFT::uint` instead of Elf_Relr.
> See above.
I guess uint would work here because the value is only stored temporarily in `R`.

That said, it looks like you could simplify the code a little by changing the code in the two branches to push values onto `RelrRelocs` directly instead of storing them in `R`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48247