[PATCH] D48851: [PM/LoopUnswitch] Fix the first and immediate components of PR37889.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Some small comments, but otherwise lgtm.



================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:282
+       OldContainingL = OldContainingL->getParentLoop()) {
+    llvm::erase_if(OldContainingL->getBlocksVector(),
+                   [&](const BasicBlock *BB) {
----------------
To better test this loop, could we have a test with deeper nesting going upward more than one loop nest? e.g. A < B < C < D, where D becomes nested in A after unswitch? 


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/nontrivial-unswitch.ll:3374
+
+define void @hoist_inner_loop_switch() {
+; CHECK-LABEL: define void @hoist_inner_loop_switch(
----------------
Comment?


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch.ll:971
+
+define void @hoist_inner_loop_switch() {
+; CHECK-LABEL: define void @hoist_inner_loop_switch(
----------------
Add comment like for the other tests?


Repository:
  rL LLVM

https://reviews.llvm.org/D48851