[PATCH] D48800: libFuzzer: prevent irrelevant strings from leaking into auto-dictionary

[pdknsk via Phabricator via llvm-commits]

pdknsk added a comment.

In https://reviews.llvm.org/D48800#1150324, @kcc wrote:

> Why is it safe to remove ScopedDoingMyOwnMemOrStr from the places you've removed it from?


Note that this removes ScopedDoingMyOwnMemOrStr completely. It's safe because the functions using it run outside the callback. MakeDictionaryEntryFromCMP before, operator== (used in ContainsWord) after, and operator< appears unused.

It'd be different if the functions (TPC.AddValueForMemcmp, TPC.MMT.Add) used inside the hooks (recursively) triggered the hooks, but that's not the case.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48800