[PATCH] D48874: [Polly] [WIP] Introduce ShapeInfo into polly.

Siddharth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 3 08:42:49 PDT 2018


bollu updated this revision to Diff 153921.
bollu added a comment.
Herald added subscribers: kbarton, nemanjai.

- Backport code to detect chapel/fortran style indexing. TODO: Codegen.

There is code in `IslExprBuilder` which is responsible for actually
lowering the multidimensional index expression. This needs to be
backported. This will be the next commit.

I had to introduce a new kind of value map for this to work, a map
from `const SCEV * -> Value *`. I hugely dislike this design, and
would love to change this.

IMO, the ShapeInfo should ideally only have `pw_aff`, since we theoretically only
understand affine accesses. However, since we _do_ allow nonaffine indexing, 
this does not work. We need some representation that is not as heavy as SCEV (?).

We need some point  in the design space which is not so painful to work
with.


Repository:
  rPLO Polly

https://reviews.llvm.org/D48874

Files:
  include/polly/ScopBuilder.h
  include/polly/ScopInfo.h
  include/polly/Support/ScopHelper.h
  lib/Analysis/ScopBuilder.cpp
  lib/Analysis/ScopDetection.cpp
  lib/Analysis/ScopInfo.cpp
  lib/CodeGen/PPCGCodeGeneration.cpp
  lib/Support/ScopHelper.cpp
  lib/Transform/ForwardOpTree.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48874.153921.patch
Type: text/x-patch
Size: 41268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180703/599bc279/attachment-0001.bin>


More information about the llvm-commits mailing list