[PATCH] D48810: [llvm-objdump] Add --file-headers (-f) option

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks fine to me, apart from a couple of test-related comments.



================
Comment at: test/tools/llvm-objdump/file-headers-coff.test:12
+# CHECK: architecture: i386
+# CHECK: start address: 0x0000
----------------
Does yaml2obj have support for PE-COFF too? If so, could you add a third test case, with a non-zero start address, please.


================
Comment at: test/tools/llvm-objdump/file-headers-elf.test:12
+# CHECK: architecture: x86_64
+# CHECK: start address: 0x0000
----------------
Could you provide a non-zero start address, please, to show that the address is correctly read.


Repository:
  rL LLVM

https://reviews.llvm.org/D48810