[PATCH] D48859: Make WindowsSupport.h a public header

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 3 08:02:08 PDT 2018


amccarth added a comment.

Will making it public cause more TUs to transitively include `<windows.h>`, or does that happen anyway?

I have no objections if the toothpaste is already out of the tube.  But if it's not, I'd prefer to keep `<windows.h>` as contained as possible, since it defines so many macros and global names that can easily conflict.


https://reviews.llvm.org/D48859





More information about the llvm-commits mailing list