[PATCH] D48872: [ARM][NFC] Refactor sequential access for DSP
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 3 05:36:27 PDT 2018
samparker added inline comments.
================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:61
ValueList VL; // List of all (narrow) operands of this Mul
- LoadInstList VecLd; // List of all load instructions of this Mul
+ MemInstList VecLd; // List of all load instructions of this Mul
MemLocList MemLocs; // All memory locations read by this Mul
----------------
SjoerdMeijer wrote:
> Nit: does the comment now needs updating? I.e., that it can be any instruction touching memory?
I don't think so. We're still expecting the ParallelMACs to operate directly on loaded data and that there aren't any stores in the chain. I will change and update this structure later - and I will try to remember to update the comments then!
https://reviews.llvm.org/D48872
More information about the llvm-commits
mailing list