D48780: [llvm-exegesis] Add an AArch64 target

[John Brawn via llvm-commits]

Fixed in r336188.

John

> -----Original Message-----
> From: Bjorn Pettersson via Phabricator [mailto:reviews at reviews.llvm.org]
> Sent: 03 July 2018 11:51
> To: John Brawn; clement.courbet at gmail.com; gchatelet at google.com; Javed
> Absar
> Cc: bjorn.a.pettersson at ericsson.com; Evgeny Astigeevich;
> mgorny at gentoo.org; Kristof Beyls; schuett at gmail.com; llvm-
> commits at lists.llvm.org; t.p.northover at gmail.com; kanheim at a-bix.com;
> mcrosier at codeaurora.org; James Molloy; junbuml at codeaurora.org;
> diana.picus at linaro.org; Florian Hahn
> Subject: [PATCH] D48780: [llvm-exegesis] Add an AArch64 target
>
> bjope added a comment.
>
> Can't build unittests (I suspect this patch):
>
>   ninja: Entering directory `build-all'
>   [1/5] Preparing lit tests
>   [2/5] Linking CXX executable unittests/Target/AArch64/AArch64Tests
>   [3/5] Building CXX object unittests/tools/llvm-
> exegesis/AArch64/CMakeFiles/LLVMExegesisAArch64Tests.dir/TargetTest.cpp.
> o
>   FAILED: unittests/tools/llvm-
> exegesis/AArch64/CMakeFiles/LLVMExegesisAArch64Tests.dir/TargetTest.cpp.
> o
>   /repo/app/clang/3.6/bin/clang++  -march=corei7  -DGTEST_HAS_RTTI=0 -
> DGTEST_HAS_TR1_TUPLE=0 -DGTEST_LANG_CXX11=1 -D_DEBUG -D_GNU_SOURCE -
> D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -
> Iunittests/tools/llvm-exegesis/AAr h64 -I../unittests/tools/llvm-
> exegesis/AArch64 -I/usr/include/libxml2 -Iinclude -I../include -
> I../tools/llvm-exegesis/lib -I../utils/unittest/googletest/include -
> I../utils/unittest/googlemock/include -I../lib/Target/AArch64 -
> Ilib/Target/AAr h64 -fPIC -fvisibility-inlines-hidden -Werror -
> Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-
> strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-
> long -Wcovered-switch-default -Wnon-virtual-dtor -Wd lete-non-virtual-
> dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-
> sections -O3    -UNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-
> macro-arguments -fno-exceptions -fno-rtti -MMD -MT unittests/tools/llvm-
> exegesis/
> Arch64/CMakeFiles/LLVMExegesisAArch64Tests.dir/TargetTest.cpp.o -MF
> unittests/tools/llvm-
> exegesis/AArch64/CMakeFiles/LLVMExegesisAArch64Tests.dir/TargetTest.cpp.
> o.d -o unittests/tools/llvm-
> exegesis/AArch64/CMakeFiles/LLVMExegesisAArch64Test
> .dir/TargetTest.cpp.o -c ../unittests/tools/llvm-
> exegesis/AArch64/TargetTest.cpp
>   ../unittests/tools/llvm-exegesis/AArch64/TargetTest.cpp:33:65: error:
> too few arguments to function call, expected 2, have 1
>     const auto Insts = Target_->setRegToConstant(llvm::AArch64::X0);
>                        ~~~~~~~~~~~~~~~~~~~~~~~~~                  ^
>   ../tools/llvm-exegesis/lib/Target.h:37:3: note: 'setRegToConstant'
> declared here
>     virtual std::vector<llvm::MCInst>
>     ^
>   1 error generated.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D48780
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.