[PATCH] D48832: [ARM] ARMCodeGenPrepare backend pass

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 3 02:15:31 PDT 2018


samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:441
+bool ARMCodeGenPrepare::isNarrowInstSupported(Instruction *I) {
+  if (!ST->hasDSP() || DisableDSP || !isSupportedType(I))
+    return false;
----------------
efriedma wrote:
> Do we need to check we have Thumb2, if we're in Thumb mode?
I thought DSP should cover it since they're only available in Thumb2, but an explicit check wouldn't hurt.


https://reviews.llvm.org/D48832





More information about the llvm-commits mailing list