[PATCH] D46653: Start support for linking object files with split stacks

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputSection.cpp:900
+    if (D->Type != STT_FUNC)
+      continue;
+    InputSection *IS = dyn_cast_or_null<InputSection>(D->Section);
----------------
MaskRay wrote:
> grimar wrote:
> > The same - untested.
> Not related to the revision. Are you using `-fprofile-arcs -ftest-coverage` + `llvm-cov` (http://lists.llvm.org/pipermail/llvm-dev/2018-April/122782.html) to collect coverage information?
Yes. 

But in simple cases (for writing/reviewing the patches, for example) just placing `assert(false)` or putting a breakpoint
is sufficient to check possible dead places.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46653