[PATCH] D48860: Make llvm.objectsize more conservative with null in non-zero address spaces

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv created this revision.
george.burgess.iv added a reviewer: arsenm.
Herald added a subscriber: wdng.

NULL in non-zero address spaces is dereferenceable/etc, so we probably shouldn't be assuming that its objectsize is zero.

arsenm: pulling you in to confirm that this change isn't breaking code you care about somehow (re: the comment from you on https://reviews.llvm.org/D28494 ). If this does break something, I'm happy to try and find some middle-ground. I'm sort of assuming the intent of that comment was more along the lines of "if this is a gcc-compat hack, we should limit it to addrspace(0), which is presumably the only place where we care," though.


https://reviews.llvm.org/D48860

Files:
  docs/LangRef.rst
  lib/Analysis/MemoryBuiltins.cpp
  test/Transforms/CodeGenPrepare/basic.ll
  test/Transforms/InstCombine/objsize.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48860.153835.patch
Type: text/x-patch
Size: 4453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180703/0510f8cc/attachment.bin>