[PATCH] D48271: [llvm-readobj] Fix printing format

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D48271#1149023, @paulsemel wrote:

> I got a build fail here : http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10648
>  As for now, I still don't know why I'm getting this error, but I guessed it was because I was passing the raw_stream..
>  This should fix this, I hope


I'd guess it's pretty unlikely that it's the passing of a raw_ostream by reference - that's a pretty common thing. To my mind, the code that looks more likely to be crashing there is that maybe the StringRef is out-of-bounds and the range-based for loop is running off the end of the underlying buffer.

Have you tried running the test under valgrind? asan? msan? things like that. You might be able to reproduce/identify the crash on your machine so you can validate a fix rather than throwing it at the buildbots again.


Repository:
  rL LLVM

https://reviews.llvm.org/D48271