[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 2 11:45:27 PDT 2018
ABataev added a comment.
In https://reviews.llvm.org/D28907#1149700, @spatel wrote:
> In https://reviews.llvm.org/D28907#1149688, @RKSimon wrote:
>
> > If not there is scope to further simplify this patch, for instance @spatel's work in InstCombine for PR37806 should mean that you can rely on InstCombine to perform much of the work in getDefaultConstantForOpcode etc. and all SLP needs to do is create a "passthrough" SK_Select shuffle stage.
>
>
> For reference in https://reviews.llvm.org/D48830, I'm proposing that we use (and extend) ConstantExpr::getBinOpIdentity(). IIUC, that would be the same thing that is shown as getDefaultConstantForOpcode() here.
Yes, I see, we can try to use it. AT least we need to think about this solution, need to estimate all pros/cons here
https://reviews.llvm.org/D28907
More information about the llvm-commits
mailing list