[PATCH] D48844: [lldbsuite, windows] Don't crash LLDB when we try to retrieve a register on Windows

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, labath, zturner.
Herald added a subscriber: llvm-commits.

1. When ReadRegister is called with a null register into on Windows, rather than crashing due to an access violation, simply return false. Not all registers and properties will be read or calculated correctly, but that is consistent with other platforms that also return false in that case
2. Update a couple of tests to reference pr37995 as their reason for failure since it is much more accurate. Support for floating point registers doesn't exist on Windows at all, rather than having issues.


Repository:
  rL LLVM

https://reviews.llvm.org/D48844

Files:
  packages/Python/lldbsuite/test/functionalities/register/intel_avx/TestYMMRegister.py
  packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py
  packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
  source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp
  source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48844.153760.patch
Type: text/x-patch
Size: 5411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180702/461c0815/attachment.bin>