[PATCH] D48674: SelectionDAGBuilder, mach-o: Skip trap after noreturn call (for Mach-O)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 11:22:59 PDT 2018


This feature was/is only enabled in -O0, though, right? As a debugging aid,
if I recall correctly - because it can be super confusing when your code
falls off the end of one function into the next. Is the code size savings
(only at O0) worth the increased cost to debug?

On Mon, Jul 2, 2018 at 10:46 AM Matthias Braun via Phabricator <
reviews at reviews.llvm.org> wrote:

> MatzeB added a comment.
>
> In https://reviews.llvm.org/D48674#1149645, @dblaikie wrote:
>
> > Out of curiosity, what's the use case/motivation for this?
>
>
> It reduces code size (0.5-1.2%) in the projects I measured.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D48674
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180702/588907b3/attachment.html>


More information about the llvm-commits mailing list