[PATCH] D48756: Add option for section ordering

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 10:12:00 PDT 2018


davide added a comment.

In https://reviews.llvm.org/D48756#1149470, @tejohnson wrote:

> This version is ok with me, question below around whether we want 2 separate options here though.
>
> Davide, did you consider changing the default for the clang driver options instead of just in gold/lld for LTO? It might also be nice to hook up -fno-function-sections and -fno-data-sections to this new gold option (and mirror it in lld), just as I had done for the affirmative versions of those options in tools::AddGoldPlugin (which is now essentially a no-op due to the default change). In which case we would want 2 separate options here (one for functions and one for data). Thoughts?


Yeah, I think it's reasonable, so, no objections from me, but I'll let Peter decide as he owns LTO.


Repository:
  rL LLVM

https://reviews.llvm.org/D48756





More information about the llvm-commits mailing list