[PATCH] D48840: [LLD][ELF][AArch64] Add test cases for load/store exclusive instructions [NFC]

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 09:54:11 PDT 2018


peter.smith created this revision.
peter.smith added reviewers: grimar, ruiu.
Herald added subscribers: kristof.beyls, arichardson, emaste.
Herald added a reviewer: javed.absar.
Herald added a reviewer: espindola.

The AArch64 -fix-cortex-a53-843419 is missing a test case for the load and store exclusive instructions. This was leading to a function not being covered in the codebase. This change adds two new instruction sequences to be recognised as an instance of the erratum, one with a load exclusive the other with a store exclusive.

This will add coverage for:

  static bool isV8NonStructureLoad(uint32_t Instr) {
    if (isLoadExclusive(Instr))
      return true;

As well as the test more thoroughly the isLoadStoreExclusive() function. The effect of adding the new tests has the unfortunate side-effect of altering the relative offsets of the branches so I've needed to update the other tests to account for it.


https://reviews.llvm.org/D48840

Files:
  test/ELF/aarch64-cortex-a53-843419-recognize.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48840.153745.patch
Type: text/x-patch
Size: 22159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180702/3f548e54/attachment.bin>


More information about the llvm-commits mailing list