[PATCH] D48803: Place the BlockAddress type in the program address space

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

In https://reviews.llvm.org/D48803#1149383, @bjope wrote:

> I don't know much about the BlockAddress concept. The LangRef says things like "always has an i8* type" and "this may be passed around as an opaque pointer sized value". But I guess it would be weird if the size doesn't match the size of pointers in the program address space, so the patch makes sense to me.
>
> I assume that this can't be reproduced for any in-tree target?
>  If you can't find an in-tree reproducer, then maybe you can describe the problem a little bit more instead. Such as which assert you hit, and maybe a small stack trace. That might help when trying to motivate this patch in the future.


Yes I'm not sure I can make a test for this with any of the existing targets. I'll see if I can get something with AVR since that sets program address space to 1.


Repository:
  rL LLVM

https://reviews.llvm.org/D48803