[PATCH] D48670: [ThinLTO] Ensure we always select the same function copy to import

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 2 09:44:09 PDT 2018


davidxl added inline comments.
Herald added a subscriber: dexonsmith.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:224
+  // i.e. with weak or linkonce linkage).
+  auto *Summary = cast<FunctionSummary>((*It)->getBaseObject());
+  if (Summary->instCount() > Threshold)
----------------
This changes the behavior in the way that a callee that could be found before this patch may no longer be found. Is this expected?


Repository:
  rL LLVM

https://reviews.llvm.org/D48670





More information about the llvm-commits mailing list