[PATCH] D46653: Start support for linking object files with split stacks

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/X86_64.cpp:505
+                                                       uint8_t *End) const {
+  llvm_unreachable("Target doesn't support split stacks.");
+}
----------------
Isn't this function the same as the function which this function overrides? Can you remove?


================
Comment at: ELF/InputSection.cpp:227-228
+    if (Defined *D = dyn_cast<Defined>(B))
+      if (D->Section == this && D->Type == STT_FUNC)
+        if (D->Value <= Offset && Offset < D->Value + D->Size)
+          return D;
----------------
if (A && B) if (C && D) → if (A && B && C && D)


================
Comment at: ELF/InputSection.cpp:890
+    // Ignore calls into the split-stack api.
+    if (D->getName().startswith("__morestack")) {
+      if (D->getName().equals("__morestack"))
----------------
What else symbol can start with `__morestack`? Is this documented?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46653