[PATCH] D48757: Implements /force:multiple in lld-link

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Can you add a test?



================
Comment at: COFF/SymbolTable.cpp:62
 
-static void errorOrWarn(const Twine &S) {
-  if (Config->Force)
+static void errorOrWarn(bool just_warn, const Twine &S) {
+  if (just_warn)
----------------
just_warn -> JustWarn




================
Comment at: COFF/SymbolTable.cpp:359
   reportDuplicate(S, F);
-  return nullptr;
+  return dyn_cast<DefinedImportData>(S);
 }
----------------
Do you have to change this


================
Comment at: COFF/SymbolTable.cpp:375
   reportDuplicate(S, ID->File);
-  return nullptr;
+  return dyn_cast<DefinedImportThunk>(S);
 }
----------------
and this?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48757