[PATCH] D48809: [FPEnv] Split double width StrictFP vector operations as needed

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added a comment.

> There's one line that I'm not too happy about. I'll add a comment inline to elucidate it.

Ah, I can't seem to add a comment inline. The line in question is lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1082...

  EVT ValueVTs[] = {OpsLo[1].getValueType(), MVT::Other};

Querying the split vector type this way, i.e. OpsLo[1].getValueType(), seems a little magic-numberish. I was contemplating using VectorType's getHalfElementsVectorType(...), but I do not see it used anywhere else in master.

Any suggestions on how to proceed?


Repository:
  rL LLVM

https://reviews.llvm.org/D48809